Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German and the French languages to the glossary #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MaMH20
Copy link
Collaborator

@MaMH20 MaMH20 commented Jun 13, 2021

Hi @bernardsilenou

I have designed the glossary website to add German and French languages and any other languages when we want. I kept it simple. :)

I worked with:

Node.js, VueJS andVuePress JS

https://github.com/vuejs/vuepress

@JonasCir
Copy link
Collaborator

I cannot do a full review:

  1. Do not delete LICENSE and README
  2. I think you are missing a GitHub Action to automatically deploy this to GitHub pages.

@JonasCir
Copy link
Collaborator

https://vuepress.vuejs.org/guide/deploy.html#github-pages should help you :)

Amazing work thank you!

@JonasCir
Copy link
Collaborator

JonasCir commented Jun 14, 2021

Also check this link: https://vuepress.vuejs.org/guide/i18n.html I think what you did differs a little bit from what is described there? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants