Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicates should require sex AND date of birth to be equal [1] #3787

Closed
MartinWahnschaffe opened this issue Dec 15, 2020 · 3 comments
Closed
Assignees
Labels
backend Affects the web backend cases change A change of an existing feature (ticket type) qa-verified Issue has been tested and verified by QA

Comments

@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Dec 15, 2020

Feature Description

Duplicate detection for retrospective merging considers some properties of the cases. Among others the sex and date of birth.

Problem Description

Currently the case is considered possible duplicate when sex OR date of birth are available and equal.

Proposed Change

Instead the logic should be an AND.
So when two cases of the same sex have a different date of birth, they should not be considered possible duplicates.

Additional info

Consider "unknown" / should not conflict with male or sth. else

@MartinWahnschaffe MartinWahnschaffe added cases change A change of an existing feature (ticket type) labels Dec 15, 2020
@MartinWahnschaffe MartinWahnschaffe added this to Sprint 98 Application in Product Backlog (deprecated) Dec 15, 2020
@MartinWahnschaffe
Copy link
Contributor Author

@bernardsilenou Please confirm.

@bernardsilenou
Copy link

@MartinWahnschaffeSymeda

  • two cases of the same sex but different date of birth should not be considered possible duplicates.
  • for two cases with missing data (NA) for one of the variables like sex for one of the cases, then this variable should not be considered in duplicate detection.

@StefanKock StefanKock moved this from Sprint 98 Application to Sprint 99 Application in Product Backlog (deprecated) Dec 17, 2020
@markusmann-vg markusmann-vg moved this from Sprint 99 Application to Sprint 98 Application in Product Backlog (deprecated) Jan 21, 2021
@markusmann-vg markusmann-vg moved this from Sprint 98 Application to Sprint 99 Application in Product Backlog (deprecated) Jan 21, 2021
@StefanKock StefanKock added the backend Affects the web backend label Jan 21, 2021
@markusmann-vg markusmann-vg changed the title Merge duplicates should require sex AND date of birth to be equal Merge duplicates should require sex AND date of birth to be equal [1] Jan 21, 2021
@markusmann-vg markusmann-vg moved this from Sprint 99 Application to Sprint 98 Application in Product Backlog (deprecated) Jan 21, 2021
@markusmann-vg markusmann-vg moved this from Sprint 98 Application to Sprint 99 Application in Product Backlog (deprecated) Jan 21, 2021
@StefanKock StefanKock added this to Backlog in Sprint Backlog Team Application (deprecated) via automation Jan 21, 2021
@BarnaBartha BarnaBartha moved this from Backlog to In Progress in Sprint Backlog Team Application (deprecated) Feb 1, 2021
@BarnaBartha BarnaBartha self-assigned this Feb 1, 2021
@BarnaBartha BarnaBartha moved this from In Progress to Review in Sprint Backlog Team Application (deprecated) Feb 1, 2021
BarnaBartha added a commit that referenced this issue Feb 2, 2021
…cateLogic

#3787 - duplicate cases should be both of same sex and birthDate
Sprint Backlog Team Application (deprecated) automation moved this from Review to Testing Feb 2, 2021
Product Backlog (deprecated) automation moved this from Sprint 99 Application to Done Feb 2, 2021
@StefanKock StefanKock added this to the Sprint 99 - 1.55.0 milestone Feb 2, 2021
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Feb 2, 2021
@AndyBakcsy-she
Copy link

Validated ticket on the latest version of Sormas version 1.55.0 snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Affects the web backend cases change A change of an existing feature (ticket type) qa-verified Issue has been tested and verified by QA
Projects
No open projects
Development

No branches or pull requests

6 participants