Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom fields with two-way-binding #9

Closed
11 tasks done
MartinWahnschaffe opened this issue Nov 28, 2016 · 2 comments
Closed
11 tasks done

Custom fields with two-way-binding #9

MartinWahnschaffe opened this issue Nov 28, 2016 · 2 comments
Assignees
@MateStrysewske
Labels
android-app Affects the Android app technology Technical issues, e.g. synchronization, libraries, plugins, etc.
Milestone
Sprint 9

Comments

@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Nov 28, 2016 •
edited by MateStrysewske
Loading

We need custom fields that implement the PropertyField interface (see SymptomStateField for comparison).

  • TextField
  • DateField (see FormTab.addDateField)
  • SpinnerField (see FormTab.makeSpinnerField; the add*SpinnerField methods probably need a better name afterwards)
  • RadioGroupField (e.g. for Contact.contactProximity)
  • Label (caption + text; e.g. Case ID in case data form)
  • Refactor existing layouts to use these fields.
  • Would be great to remove FormTab.getModel.
  • Refactoring (-> outsource spinner creation methods)
  • Replace age and phone fields with number fields
  • Bug: age field edit is not saved
  • Bug: Districts and communities are selectable no matter which region/district has been chosen in location dialog
@MartinWahnschaffe MartinWahnschaffe added the android-app Affects the Android app label Nov 28, 2016
@MartinWahnschaffe MartinWahnschaffe added this to the Sprint 9 milestone Nov 28, 2016
@MateStrysewske
Copy link
Contributor

Strings in fieldCaptions.properties sometimes don't match those in the app layout files - which ones should be used?

@MartinWahnschaffe
Copy link
Contributor Author

MartinWahnschaffe commented Nov 30, 2016 via email

@MartinWahnschaffe MartinWahnschaffe added the technology Technical issues, e.g. synchronization, libraries, plugins, etc. label Dec 1, 2016
MateStrysewske added a commit that referenced this issue Dec 5, 2016
@MateStrysewske
#9 - custom fields and layout files
ae7f157
MateStrysewske added a commit that referenced this issue Dec 5, 2016
@MateStrysewske
#9 - moved binding adapters to their respective field classes
ad128db
MateStrysewske added a commit that referenced this issue Dec 7, 2016
@MateStrysewske
#9 - removed model from classes, replaced android views with custom f…
5e8882c 
…ields, changed ratio of caption and buttons in yes_no field, refactoring

# Conflicts:
#	sormas-api/src/main/resources/fieldCaptions.properties
MateStrysewske added a commit that referenced this issue Dec 7, 2016
@MateStrysewske
#9 - removed item list from spinner field (replaced with adapter), fi…
fb2e7f0 
…xed new person not being selected when creating a new tab, fixed date field popping up on tab focus
MateStrysewske added a commit that referenced this issue Dec 7, 2016
@MateStrysewske
#9 - refactoring
4b33e1b
MateStrysewske added a commit that referenced this issue Dec 7, 2016
@MateStrysewske
#9 - added radio group custom field, added radio group to contact edi…
26710a0 
…t data tab
MateStrysewske added a commit that referenced this issue Dec 8, 2016
@MateStrysewske
#9 - refactoring and bug fixes, date field popup fix
2e67ee3
MateStrysewske added a commit that referenced this issue Dec 8, 2016
@MateStrysewske
#9 - removed remaining redundant layouts
2ac1c65
MateStrysewske added a commit that referenced this issue Dec 8, 2016
@MateStrysewske
#9 - changed findViewById() calls to binding calls, fixed a bug with …
f5bd632 
…death date
MateStrysewske added a commit that referenced this issue Dec 9, 2016
@MateStrysewske
#9 - outsourced spinner field listener registration
3599d5c
MateStrysewske added a commit that referenced this issue Dec 9, 2016
@MateStrysewske
#9 - added spinner field listener
5d769f7
@StefanSzczesny StefanSzczesny mentioned this issue Dec 12, 2016
Closed
MateStrysewske pushed a commit that referenced this issue Oct 27, 2020
@syntakker @JoshuaRenckens
@JonasCir @s8jorenc @DavidBaldsiefen
[IMIS] #2696 document generation quarantine (#3184)
4294320 
* move TemplateEngineService to new branch (#8)

* TemplateEngineService EJB Test (#8)

* Generic test cases for TemplateEngineService (#8)

* use system's default charset (#8)

* revert: use system's default charset (#8)

* normalize Windows line ending (#8)

* normalize Windows line ending (#8)

* move TemplateEngineService to new branch (#8)

* TemplateEngineService EJB Test (#8)

* Generic test cases for TemplateEngineService (#8)

* use system's default charset (#8)

* revert: use system's default charset (#8)

* normalize Windows line ending (#8)

* normalize Windows line ending (#8)

* rudimentary QuarantineOrderFacade + Test (#8)

* add quarantine button mockup (#8)

* technical Durchstich :-) (#8)

* extra template testcase written in Word

* remove obsolete line ending cleanup (#8)

* Change wording to "Quarantine order" (#8)

* Create GUIDE_DOCUMENT_GENERATION.md

* Quarantine test docx, Issue #8

* EntityDtoAccessHelper for variable name mapping (#8)

* EntityDtoAccessHelper for variable name mapping (#8)

* EntityDtoAccessHelper property as String (#8)

* Fixes and test case (#8)

* Quarantine.docx in cargo server (#8)

* cleanup

* Fix docx templates (#8)

* Fix docx templates (#8)

* Allow property access in templates (#8)

* read available templates (#8)

* added proper i18n label and caption

* template selection (#9)

* template selection (cleanup) (#9)

* preliminary template upload (#5)

* added rudimentary template-management-ui (#6)

* Merge

* template variables + preliminary template delete (#5)

* assert sucessful template deletion (#5)

* read additional variables (#8)

* Added rudimentary template management and ui (#6 and #4)

* integrate additional variables in UI (#9)

* textfield width (#9)

* fix deselect template (#9)

* Improved Template-Management UI (#6)

* QuarantineOrderFacade.getTemplate (#8)

* Added functionality to view-template buttn (#6)

* Validate templates (#8)

* Check if template exists (#8)

* Replace IllegalArgumentException by ValidationException (#8)

* Fix QuarantineOrderComponent (#9)

* Added error handling (#6)(#4)

* improved error messages #6

* Various Template UI improvements (#6)

* Added user right DOCUMENT_TEMPLATE_MANAGEMENT (#4)

* Refactored 'Template...' to 'DocumentTemplate...'

* Popup window for document generation (#9)

* Fix validateTemplateTest for Windows (#8)

* Added full i18n support (#6)

* Document Template Guide (#4)

* Link to Document Template Guide in UI (#9)

* Fix typo (#9)

* Quarantine order for contacts (#9)
Fix I18N test

* Test for wrong ReferenceDto type (#8)

* User Right QUARANTINE_ORDER_CREATE (#9)

* cleanup (#9)

* hide quarantine box unless quarantine is HOME or INSTITUTIONELL (#9)

* cleanup Strings and Captions (#9)

* cleanup Strings and Captions (#9)

* fix merge

* refactor (#9)

* fix translation DE (#9)

* exclude admin from QUARANTINE_ORDER_CREATE (only pseudonymized data access) (#9)

* Secure against writing outside template directory (#8)

* Complete I18N (#9)

* QuarantineType.isQuarantineInEffect, unify with visibility of quarantine fields  (#9)

* reset I18nConstantsUpdatedTest (#9)

* Update SORMAS_Data_Dictionary.xlsx and SORMAS_User_Rights.xlsx (#9)

* fix merge (#9)

* merge bugfix #3198

* fix onValueChange (fixes #3198)

* Document Example Templates (#9)

* script ui build and redeploy (#9)

* Document Example Template Word (#9)

* PR #3184 remove de.symeda.sormas.ui.configuration.infrastructure.QuarantineTemplatesGrid

* PR #3184 fix import order

* PR #3184 remove obsolete condition

* PR #3184 use StringUtils.isNotBlank

* PR #3184 fix issues from comments

* PR #3184 remove obsolete redeployUI.sh

* PR #3184 fix issues from comments

* PR #3184 rename MS Word to Microsoft Word

* PR #3184 remove logging

* PR #3184 add explanation of ROOT_ENTITY_NAME

* PR #3184 use specific exception types

* PR #3184 UI fixes

* PR #3184 adjust spacing in UI

* PR #3184 delete obsolete password.txt

* PR #3184 update SORMAS_Data_Dictionary and SORMAS_User_Rights after merge

Co-authored-by: Joshua <justgivemeanacceptablemail@gmail.com>
Co-authored-by: Jonas Cirotzki <s8jociro@stud.uni-saarland.de>
Co-authored-by: s8jorenc <57158691+s8jorenc@users.noreply.github.com>
Co-authored-by: David <david.baldsiefen@stud-mail.uni-wuerzburg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MateStrysewske MateStrysewske

Labels
android-app Affects the Android app technology Technical issues, e.g. synchronization, libraries, plugins, etc.
Projects
None yet
Milestone
Sprint 9
Development

No branches or pull requests
2 participants
@MartinWahnschaffe @MateStrysewske