-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: improving events management #8
Conversation
1b71518
to
3090696
Compare
Fixes #7, by using a proper, more solid way to correctly save and validate the forms. No longer can you add an event without anything in it!
- Removed points from urls.py - Simplified some parts of the tests - Furthermore added permissions checking for the events add and edit
Should work fine, seeing as we have raise_exception to True per default.
Addition of test is due to failing view of invoices, due to relying on event.get_cost() and event.get_hours(), which is now just event.cost and event.hours. :)
Now use {% set %} to do all titles, as well as "title_small". Note that we can also use block assignments. :)
- Added help_text to select fields of Event. - Improved columns for tables - Tweaked the utils macro
Fixes #6 somewhat. Note that the error message is not the most helpful, but it'll do until there's an exact one for the minimum value.
Conclusion: no need to add pagination right now, because the list isn't yet that long. I'll create a separate issue to track pagination of the events view. Calendar is still on the todo, but waiting for that is detrimental to anything else. There are some Django apps like django-scheduler that can help with this, but they're somewhat more complex than I really care for. All I need is to display it, and that's about where the similarities end. |
Background
Editing events is very bare-bones at the moment, and lacks a lot of features that would make it generally more usable for... anything.
In terms of the code, it can now be swapped over to use parts of CBV, although with inlines and whatnot there'll always be some mess.
Rough plan