This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Enforce JSON Object Literals in HTTP #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefringeninja
force-pushed
the
j-wowject
branch
from
e84bdad
to
ddc2a1b
Compare
thefringeninja
changed the title
thefringeninja
force-pushed
the
j-wowject
branch
from
11a65f7
to
d686cb8
Compare
thefringeninja
changed the title
damianh
reviewed
Feb 13, 2019
| payload = FromString(payload), | ||
| metadata = FromString(message.JsonMetadata) | ||
| }) | ||
| { } |
There was a problem hiding this comment.
I'd have done an extension method instead of inheritance
streamMessage.ToHalResponse()
Minor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should make #250 possible