Remove chapters with non-matching media type #838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some RTS Forum video episodes (e.g.
urn:rts:video:14827796
) are delivered with the corresponding full-length audio as part of the chapter list, withfullLengthMarkin
andfullLengthMarkOut
both set to zero. The resulting behavior is awkward:Though this could be seen as a backend or metadata issue, the media composition is flexible enough to allow such use cases. Letterbox also currently supports such use cases, though the user experience might be awkward (tapping on the audio content makes the context switch to the audio-only context).
For the moment I think we sadly have to fix the issue client-side. This is what this PR does by parsing the media type and ensuring chapters all have the same media type as the main content.
Changes made
Checklist