Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chapters with non-matching media type #838

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

defagos
Copy link
Member

@defagos defagos commented Apr 22, 2024

Description

Some RTS Forum video episodes (e.g. urn:rts:video:14827796) are delivered with the corresponding full-length audio as part of the chapter list, with fullLengthMarkin and fullLengthMarkOut both set to zero. The resulting behavior is awkward:

IMG_2519

Though this could be seen as a backend or metadata issue, the media composition is flexible enough to allow such use cases. Letterbox also currently supports such use cases, though the user experience might be awkward (tapping on the audio content makes the context switch to the audio-only context).

For the moment I think we sadly have to fix the issue client-side. This is what this PR does by parsing the media type and ensuring chapters all have the same media type as the main content.

Changes made

  • Update parsing to extract media type from metadata.
  • Update condition used to associate chapters with the content being played.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos added the enhancement New feature or request label Apr 22, 2024
@defagos defagos added this to the Metadata milestone Apr 22, 2024
@defagos defagos self-assigned this Apr 22, 2024
@waliid waliid added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 5282b7d Apr 22, 2024
6 checks passed
@waliid waliid deleted the chapter-type-consistency branch April 22, 2024 07:17
@defagos defagos mentioned this pull request Apr 22, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants