Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for mixed chapter filtering #841

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add test for mixed chapter filtering #841

merged 1 commit into from
Apr 22, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Apr 22, 2024

Description

I was clearly lazy in #838. The newly added condition deserves a test, which this PR adds.

Changes made

Self-explanatory. Original data has been edited so that both parent chapter URN and media type matching are tested.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this Apr 22, 2024
@defagos defagos added the enhancement New feature or request label Apr 22, 2024
@defagos defagos added this to the Metadata milestone Apr 22, 2024
@defagos defagos enabled auto-merge April 22, 2024 07:26
@defagos defagos added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 80f5526 Apr 22, 2024
6 checks passed
@defagos defagos deleted the chapters-unit-test branch April 22, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees

@defagos defagos

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
Metadata
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@defagos @waliid