Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return invalid times and ranges consistently with other player APIs #847

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Return invalid times and ranges consistently with other player APIs #847

merged 1 commit into from
Apr 24, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Apr 24, 2024

Description

This PR improves API consistency between ProgressTracker and Player when requesting time or time range information.

Changes made

  • Return .invalid times and ranges from ProgressTracker instead of nil when unknown.
  • Update documentation.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos added the enhancement New feature or request label Apr 24, 2024
@waliid waliid enabled auto-merge April 24, 2024 14:35
@waliid waliid added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit e9bfd1a Apr 24, 2024
6 checks passed
@waliid waliid deleted the api-consistency branch April 24, 2024 14:49
@defagos defagos mentioned this pull request Apr 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees

@defagos defagos

@waliid waliid

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@defagos @waliid