Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertion raised when formatting invalid times #848

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix assertion raised when formatting invalid times #848

merged 1 commit into from
Apr 25, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Apr 24, 2024

Description

This PR fixes an assertion raised in debug builds, following changes made in #847.

Changes made

  • Check that times are valid before attempting to format values in seconds derived from them.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this Apr 24, 2024
@defagos defagos added the bug Something isn't working label Apr 24, 2024
@defagos defagos enabled auto-merge April 24, 2024 17:39
@defagos defagos added this pull request to the merge queue Apr 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2024
@defagos defagos added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit fda8dae Apr 25, 2024
6 checks passed
@defagos defagos deleted the assertion-fix branch April 25, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees

@defagos defagos

Labels
bug Something isn't working
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@defagos @waliid