Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undesired animation #881

Merged
merged 10 commits into from
May 15, 2024
Merged

Fix undesired animation #881

merged 10 commits into from
May 15, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented May 15, 2024

Description

This PR allows us to fix an undesired animation on the metadata view.

Changes made

  • Renames some computed variables.
  • Uses same logic for opacities.
  • Hides bottom buttons when the UI should be hidden.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid self-assigned this May 15, 2024
@waliid waliid added the bug Something isn't working label May 15, 2024
Copy link
Member

@defagos defagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two other remarks while I was looking at the code (not related to your changes):

  • .linear(duration: 0.2) should just be .defaultLinear.
  • The Self in static let defaultLinear = Self.linear(duration: 0.2) can be removed.

Would you mind doing these changes and commit them? Thanks in advance!

@waliid waliid enabled auto-merge May 15, 2024 18:37
@defagos defagos self-requested a review May 15, 2024 18:40
@waliid waliid added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@waliid waliid added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 12d49c8 May 15, 2024
6 checks passed
@waliid waliid deleted the fix-undesired-animation branch May 15, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants