Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid settings menu being closed when controls disappear #883

Merged
merged 1 commit into from
May 16, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented May 16, 2024

Description

This PR fixes a minor regression introduced in #881, in which bottom buttons (including the settings menu button) were removed from the hierarchy with hidden controls.

Due to current limitations with SwiftUI Menu API (see #384) we currently cannot prevent controls from disappearing while the menu is open. As a result the change in #881 was closing the menu while the user was picking a speed or tracks during playback. To reproduce:

  1. Open the demo nightly build 429.
  2. Play the first SWI video example. Do not pause playback.
  3. Open the settings menu and wait. The menu is dismissed when controls are hidden.

Changes made

  • Use opacity to hide bottom bar buttons while in full-screen layout.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this May 16, 2024
@defagos defagos added the bug Something isn't working label May 16, 2024
@defagos defagos enabled auto-merge May 16, 2024 04:55
@defagos defagos added this pull request to the merge queue May 16, 2024
@waliid
Copy link
Member

waliid commented May 16, 2024

Thanks! I really appreciate this iteration.

Merged via the queue into main with commit a8c91d9 May 16, 2024
6 checks passed
@defagos defagos deleted the settings-button-fix branch May 16, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants