Avoid settings menu being closed when controls disappear #883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a minor regression introduced in #881, in which bottom buttons (including the settings menu button) were removed from the hierarchy with hidden controls.
Due to current limitations with SwiftUI
Menu
API (see #384) we currently cannot prevent controls from disappearing while the menu is open. As a result the change in #881 was closing the menu while the user was picking a speed or tracks during playback. To reproduce:Changes made
Checklist