Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta and TestFlight builds use one tag Github deployment #464

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Apr 23, 2024

Motivation and Context

Thanks to #447, and beta update #454, tag deployments are implemented.
We can now follow the production rules: no multiple tag deployments on Beta and TestFlight builds as well.
Just update the current tag deployment if exist and not succeeded. Ignore running for just update distribution.

Description

  • Check if tag deployment exist for Beta and AppStore builds. Update the deployment states if no already succeed.
  • If the tag deployment exist and already succeed, do not create a new deployment.

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

@pyby pyby added dev tool Dev tool improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section labels Apr 23, 2024
@pyby pyby added this pull request to the merge queue Apr 24, 2024
Merged via the queue into develop with commit 3fe4394 Apr 24, 2024
1 check passed
@pyby pyby deleted the feature/ci-update branch April 24, 2024 16:29
@pyby pyby changed the title Feature/ci update Beta and TestFlight builds use one tag Github deployment Apr 24, 2024
@pyby
Copy link
Member Author

pyby commented Apr 25, 2024

Not working as expected when tested "AppstoreBuilds" for public TestFlight builds. Not started with a tag deployment, either a branch name deployment, but still with a commit sha. Needs more investigation.

@pyby pyby added CI CI workflow improvement or update (issue and PR) - release notes section and removed dev tool Dev tool improvement or update (issue and PR) - release notes section labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI workflow improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant