Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assertion with simple log #286

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Replace assertion with simple log #286

merged 1 commit into from
Oct 28, 2022

Conversation

defagos
Copy link
Member

@defagos defagos commented Oct 28, 2022

Pull request

Description

This PR avoids crashing unit tests during font registration.

Changes made

I replaced the assertion with an NSLog. Using NSLog is in general bad practice but here this is just for warning purposes. Adding a dependency on SRGLogger or using os_log seemed also a bit too much.

@defagos defagos linked an issue Oct 28, 2022 that may be closed by this pull request
Font registration assertion in unit tests #285
Closed
@defagos defagos requested a review from pyby October 28, 2022 05:44
pyby
pyby approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@pyby pyby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests with swift code base and a SPM integration loads twice the constructor in different processes but same "application".

It's not the case in other target types, like an iOS application.

@pyby pyby added the minor bug label Oct 28, 2022
@pyby pyby merged commit 0fe0b3c into develop Oct 28, 2022
@pyby pyby deleted the feature/285-font-registration-assertion-in-unit-tests branch October 28, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyby pyby pyby approved these changes

Assignees
No one assigned
Labels
minor bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font registration assertion in unit tests
2 participants
@defagos @pyby