Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect ordering of the ase cell #306

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

yzjin
Copy link
Collaborator

@yzjin yzjin commented Mar 6, 2024

Storing the cell from an ASE MD environment currently will perform a transpose unintentionally. This error is usually harmless, but will cause problems when the cell is triclinic and restarting from a previous state. This pull request fixes this problem.

Copy link

trunk-io bot commented Mar 6, 2024

❌ Failed to start running tests on this pull request. (details)

@pabloferz pabloferz merged commit 2da7c79 into SSAGESLabs:main Mar 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants