Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force_calculated not correctly updated when compute_ensemble is called #193

Open
mesonepigreco opened this issue Feb 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mesonepigreco
Copy link
Collaborator

From discussion #187

After using the compute_ensemble with cluster. I can see the ensemble.force correctly store all the calculated results and therefore the ensemble.save_bin can save these results into .npy format. However, it seems the flag of ensemble.force_calculated is not set to be True so that the function ensemble.save does not save all the forces.

@mesonepigreco
Copy link
Collaborator Author

Probably, this is fixed in the last version, 1.4.1, by the commit mentioned.

@mesonepigreco
Copy link
Collaborator Author

Not, it has not.
The problem is that when the cluster is invoked in the calculation, the flags force_computed and stress_computed are not set when the configuration is compiled. Instead, this should have been fixed for the AiiDA ensemble and the generic ASE calculator. So, the problem occurs in the subroutine compute_cluster_batch of the Cluster.py file

mesonepigreco added a commit that referenced this issue Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant