-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple domains tests to responder_cache_req-tests #3920
Labels
Comments
ikerexxe
added a commit
to ikerexxe/sssd
that referenced
this issue
Jul 6, 2020
Test users_by_filter_multiple_domains_valid was removed in the past and this commit adds it back. Explanation: Given two users are present When the users are searched by filtering domains Then the two users are returned correctly. Resolves: SSSD#3920
ikerexxe
added a commit
to ikerexxe/sssd
that referenced
this issue
Jul 6, 2020
Test groups_by_filter_multiple_domains_valid was removed in the past and this commit adds it back. Explanation: Given two groups are present When the groups are searched by filtering domains Then the two groups are returned correctly. Resolves: SSSD#3920
ikerexxe
added a commit
to ikerexxe/sssd
that referenced
this issue
Jul 20, 2020
Test users_by_filter_multiple_domains_valid was removed in [1] because it was failing. Apparently, the failure was related with a filter that caused that only users added after the request was started to be returned. When adding back the test I haven't found that problem, but another one related with memory handling in the test itself. The failure was related with a filter, added when calling cache_req_group_fy_filter_send(), that causes that only users added after the request started are returned. This commit adds back the test after fixing several problems related with memory handling in the test itself. Explanation of the test: Given two users are present When the users are searched by filtering domains Then the two users are returned correctly. Resolves: SSSD#3920 Links: [1] SSSD@bdf422f
ikerexxe
added a commit
to ikerexxe/sssd
that referenced
this issue
Jul 20, 2020
Test groups_by_filter_multiple_domains_valid was removed in [1] because it was failing. Apparently, the failure was related with a filter that caused that only groups added after the request was started to be returned. When adding back the test I haven't found that problem, but another one related with memory handling in the test itself. This commit adds back the test after fixing several problems related with memory handling in the test itself. Explanation of the test: Given two groups are present When the groups are searched by filtering domains Then the two groups are returned correctly. Resolves: SSSD#3920 Links: [1] SSSD@bdf422f
pbrezina
pushed a commit
that referenced
this issue
Jul 21, 2020
Test groups_by_filter_multiple_domains_valid was removed in [1] because it was failing. Apparently, the failure was related with a filter that caused that only groups added after the request was started to be returned. When adding back the test I haven't found that problem, but another one related with memory handling in the test itself. This commit adds back the test after fixing several problems related with memory handling in the test itself. Explanation of the test: Given two groups are present When the groups are searched by filtering domains Then the two groups are returned correctly. Resolves: #3920 Links: [1] bdf422f Reviewed-by: Pawel Polawski <ppolawsk@redhat.com>
alexey-tikhonov
pushed a commit
to alexey-tikhonov/sssd
that referenced
this issue
Jul 21, 2020
Test groups_by_filter_multiple_domains_valid was removed in [1] because it was failing. Apparently, the failure was related with a filter that caused that only groups added after the request was started to be returned. When adding back the test I haven't found that problem, but another one related with memory handling in the test itself. This commit adds back the test after fixing several problems related with memory handling in the test itself. Explanation of the test: Given two groups are present When the groups are searched by filtering domains Then the two groups are returned correctly. Resolves: SSSD#3920 Links: [1] SSSD@bdf422f Reviewed-by: Pawel Polawski <ppolawsk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/2879
We removed those two tests:
in https://fedorahosted.org/sssd/ticket/2730
We could fix their logic and get them back to tests.
Comments
Comment from jhrozek at 2015-11-25 15:36:58
Getting this interface tested is a prerequisite for using the cache_req interface in NSS responder, which is currently 1.14. We might bump it out to 1.15, but for now the tickets should go together.
Comment from jhrozek at 2015-11-26 17:15:14
Since this is not required for the NSS conversion but only for the IFP tests, 1.15 is fine.
milestone: NEEDS_TRIAGE => SSSD 1.15 beta
Comment from jhrozek at 2015-12-03 22:13:27
Fields changed
rhbz: => 0
Comment from jhrozek at 2016-08-04 10:15:01
Fields changed
keywords: => easyfix
Comment from pcech at 2017-02-24 14:51:49
Metadata Update from @pcech:
Comment from jhrozek at 2017-07-12 14:07:58
Metadata Update from @jhrozek:
Comment from thalman at 2020-03-11 15:50:21
Metadata Update from @thalman:
The text was updated successfully, but these errors were encountered: