Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that if two certificate matching rules with the same priority match only one is used #4415

Closed
sssd-bot opened this issue May 2, 2020 · 2 comments
Labels
Bugzilla Closed: Fixed Issue was closed as fixed.

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/3388


If two or more certificate matching rules with the same priority match SSSD should generate a LDAP search filter where the individual search filters are or-ed together (|(rule1)(rule2)....(ruleN)).

Currently only the filter from one of the rules is used.

Work-around: Create a single combined certmap rule where the filters from the individual rules are or-ed together.

Comments


Comment from spoore at 2017-05-02 17:14:58

FYI, example where I saw this:

ipa certmaprule-add testrule1 --matchrule='CN=Certificate Authority,O=TESTRELM.TEST' --maprule='(ipacertmapdata=X509:{issuer_dn!nss_x500}{subject_dn!nss_x500})'

ipa certmaprule-add wholecert --matchrule='CN=Certificate Authority,O=TESTRELM.TEST' --maprule='(userCertificate;binary={cert!bin})'

systemctl stop sssd; rm -rf /var/lib/sss/{db,mc}/*; systemctl start sssd

dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe/Users org.freedesktop.sssd.infopipe.Users.FindByCertificate string:"$(cat testuser1.crt)"

would sometimes fail if user had either whole cert or certmapdata.


Comment from jhrozek at 2017-05-03 22:27:46

Metadata Update from @jhrozek:


Comment from jhrozek at 2017-05-03 22:27:46

Metadata Update from @jhrozek:


Comment from jhrozek at 2017-05-03 22:27:46

Issue linked to Bugzilla: Bug 1447098


Comment from jhrozek at 2017-05-04 11:49:16

Metadata Update from @jhrozek:


Comment from jhrozek at 2017-05-04 11:49:16

Metadata Update from @jhrozek:


Comment from jhrozek at 2017-05-04 11:49:16

Issue linked to Bugzilla: Bug 1447945


Comment from jhrozek at 2017-05-04 11:49:48

Metadata Update from @jhrozek:


Comment from jhrozek at 2017-05-04 15:55:53

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD 1.15.3

Comment from jhrozek at 2017-05-04 16:28:55

Metadata Update from @jhrozek:

  • Issue priority set to: major

Comment from jhrozek at 2017-06-28 17:43:15

Since upstream would like to release a next tarball quite soon, but at the same time this issue is not a blocker, I'm moving it to the next milestone.


Comment from jhrozek at 2017-06-28 17:43:36

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD 1.15.4 (was: SSSD 1.15.3)

Comment from jhrozek at 2017-08-10 13:37:54

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD 1.16.0 (was: SSSD 1.15.4)

Comment from jhrozek at 2017-10-19 20:21:35

Since we are required to release a new upstream tarball no later than Friday Oct-20, I'm moving tickets that will not be closed by that date to the next milestone, 1.16.1


Comment from jhrozek at 2017-10-19 20:21:37

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD 1.16.1 (was: SSSD 1.16.0)

Comment from jhrozek at 2017-12-15 19:57:40

Metadata Update from @jhrozek:

  • Issue tagged with: postpone-to-2-0

Comment from jhrozek at 2018-01-08 17:55:48

Metadata Update from @jhrozek:

  • Issue untagged with: postpone-to-2-0
  • Issue set to the milestone: SSSD 2.0 (was: SSSD 1.16.1)

Comment from jhrozek at 2018-08-13 10:14:16

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD 2.1 (was: SSSD 2.0)

Comment from jhrozek at 2019-02-22 15:50:04

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD 2.2 (was: SSSD 2.1)

Comment from jhrozek at 2019-06-13 23:22:05

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD 2.3 (was: SSSD 2.2)

Comment from thalman at 2020-03-11 11:59:01

Metadata Update from @thalman:

  • Issue tagged with: bugzilla
@sumit-bose sumit-bose changed the title If two certificate matching rules with the same priority match only one is used Document that if two certificate matching rules with the same priority match only one is used Apr 27, 2021
@sumit-bose
Copy link
Contributor

Hi,

the purpose of this ticket is changed to document the current behavior and not change it to avoid incompatibilities with older versions.

bye,
Sumit

sumit-bose added a commit to sumit-bose/sssd that referenced this issue Apr 27, 2021
Explain in the man page what is expected when two or more mapping and
matching rules have the same priority.

Resolves: SSSD#4415
sumit-bose added a commit to sumit-bose/sssd that referenced this issue Apr 28, 2021
Explain in the man page what is expected when two or more mapping and
matching rules have the same priority.

Resolves: SSSD#4415
@pbrezina
Copy link
Member

Pushed PR: #5611

  • master
    • 7313efb - man: clarify priority in sss-certmap man page

@pbrezina pbrezina added the Closed: Fixed Issue was closed as fixed. label Apr 30, 2021
akuster pushed a commit to akuster/sssd that referenced this issue May 18, 2021
Explain in the man page what is expected when two or more mapping and
matching rules have the same priority.

Resolves: SSSD#4415

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugzilla Closed: Fixed Issue was closed as fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants