Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IFP: org.freedesktop.sssd.infopipe.GetUserGroups does not take SYSDB_PRIMARY_GROUP_GIDNUM into account #4569

Closed
sssd-bot opened this issue May 2, 2020 · 1 comment
Closed

IFP: org.freedesktop.sssd.infopipe.GetUserGroups does not take SYSDB_PRIMARY_GROUP_GIDNUM into account #4569

sssd-bot opened this issue May 2, 2020 · 1 comment
Assignees
@ikerexxe
Labels
Closed: Fixed Issue was closed as fixed. Next milestone

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/3543

  • Created at 2017-10-09 20:41:48 by jhrozek
  • Assigned to nobody

With a domain that auto-creates user private groups, we still save the original GID into the SYSDB_PRIMARY_GROUP_GIDNUM attribute and then we also return this GID in nss_protocol_fill_initgr.

But we don't do any such thing in GetUserGroups, which leads to a different set of groups being reported via the IFP interface and the NSS interface.

Comments

Comment from jhrozek at 2017-10-31 22:32:24

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD Future releases (no date set yet)

Comment from thalman at 2020-03-11 14:32:20

We need to verify current status of this issue

Comment from thalman at 2020-03-11 14:32:20

Metadata Update from @thalman:

  • Issue tagged with: Next milestone
@ikerexxe ikerexxe self-assigned this Jul 21, 2020
ikerexxe added a commit to ikerexxe/sssd that referenced this issue Aug 13, 2020
@ikerexxe
responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM
a2c166e 
There was a mismatch between the information provided by NSS and IFP
interfaces. nss_protocol_fill_initgr() returned
SYSDB_PRIMARY_GROUP_GIDNUM, but GetUserGroups() didn't. This commit
makes GetUserGroups() also return SYSDB_PRIMARY_GROUP_GIDNUM value.

Resolves:
SSSD#4569
@ikerexxe ikerexxe mentioned this issue Aug 13, 2020
Closed
ikerexxe added a commit to ikerexxe/sssd that referenced this issue Aug 13, 2020
@ikerexxe
responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM
7c59663 
There was a mismatch between the information provided by NSS and IFP
interfaces. nss_protocol_fill_initgr() returned
SYSDB_PRIMARY_GROUP_GIDNUM, but GetUserGroups() didn't. This commit
makes GetUserGroups() also return SYSDB_PRIMARY_GROUP_GIDNUM value.

Resolves:
SSSD#4569
ikerexxe added a commit to ikerexxe/sssd that referenced this issue Aug 24, 2020
@ikerexxe
IFP: GetUserGroups() returns origPrimaryGroupGidNumber
ea30725 
There was a mismatch between the information provided by NSS and IFP
interfaces. nss_protocol_fill_initgr() returned
origPrimaryGroupGidNumber as one of the group members of a user, but
GetUserGroups() didn't. This commit makes GetUserGroups() also return
origPrimaryGroupGidNumber value.

Resolves:
SSSD#4569
ikerexxe added a commit to ikerexxe/sssd that referenced this issue Aug 24, 2020
@ikerexxe
IFP-TESTS: GetUserGroups() returns origPrimaryGroupGidNumber
33ab292 
New infopipe test case to check:
Given auto_private_groups is enabled
When GetUserGroups is called
Then the origPrimaryGroupGidNumber is returned as part of the group
memberships

Resolves:
SSSD#4569
ikerexxe added a commit to ikerexxe/sssd that referenced this issue Aug 24, 2020
@ikerexxe
IFP-TESTS: GetUserGroups() returns origPrimaryGroupGidNumber
05b432f 
New infopipe test case to check:
Given auto_private_groups is enabled
When GetUserGroups is called
Then the origPrimaryGroupGidNumber is returned as part of the group
memberships

Resolves:
SSSD#4569
ikerexxe added a commit to ikerexxe/sssd that referenced this issue Sep 30, 2020
@ikerexxe
IFP: GetUserGroups() returns origPrimaryGroupGidNumber
34de034 
There was a mismatch between the information provided by NSS and IFP
interfaces. nss_protocol_fill_initgr() returned
origPrimaryGroupGidNumber as one of the group members of a user, but
GetUserGroups() didn't. This commit makes GetUserGroups() also return
origPrimaryGroupGidNumber value.

Resolves:
SSSD#4569
ikerexxe added a commit to ikerexxe/sssd that referenced this issue Sep 30, 2020
@ikerexxe
IFP-TESTS: GetUserGroups() returns origPrimaryGroupGidNumber
7b95c2f 
New infopipe test case to check:
Given auto_private_groups is enabled
When GetUserGroups is called
Then the origPrimaryGroupGidNumber is returned as part of the group
memberships

Resolves:
SSSD#4569
pbrezina pushed a commit that referenced this issue Oct 1, 2020
@ikerexxe @pbrezina
IFP-TESTS: GetUserGroups() returns origPrimaryGroupGidNumber
5ddabed 
New infopipe test case to check:
Given auto_private_groups is enabled
When GetUserGroups is called
Then the origPrimaryGroupGidNumber is returned as part of the group
memberships

Resolves:
#4569

Reviewed-by: Sumit Bose <sbose@redhat.com>
@pbrezina
Copy link
Member

pbrezina commented Oct 1, 2020

Pushed PR: #5272

  • master
    • 5ddabed - IFP-TESTS: GetUserGroups() returns origPrimaryGroupGidNumber
    • 49481da - IFP: GetUserGroups() returns origPrimaryGroupGidNumber

@pbrezina pbrezina added the Closed: Fixed Issue was closed as fixed. label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikerexxe ikerexxe

Labels
Closed: Fixed Issue was closed as fixed. Next milestone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ikerexxe @pbrezina @sssd-bot