Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sssd_be segfaults at be_refresh_get_values_ex() due to NULL ptrs in results of sysdb_search_with_ts_attr() #5412

Closed
alexey-tikhonov opened this issue Nov 20, 2020 · 1 comment
Closed

sssd_be segfaults at be_refresh_get_values_ex() due to NULL ptrs in results of sysdb_search_with_ts_attr() #5412

alexey-tikhonov opened this issue Nov 20, 2020 · 1 comment
Assignees
@alexey-tikhonov
Labels
Bugzilla Closed: Fixed Issue was closed as fixed.

Comments

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 20, 2020 •
edited

sssd/src/db/sysdb_search.c

Line 252 in d93b4fe

/* non-fatal, we just get only the non-timestamp attrs */

Despite what comment says, in case merge_msg_sysdb_attrs() fails here ^^ ts_cache_res is left zero-initialized and eventually is dereferenced in be_refresh_get_values_ex() -> sysdb_msg2attrs() resulting in a segfault.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1899593
@alexey-tikhonov alexey-tikhonov self-assigned this Nov 20, 2020
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this issue Nov 22, 2020
@alexey-tikhonov
SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[]
3290454 
This helps to avoid sssd_be segfaults at be_refresh_get_values_ex() due to NULL
ptrs in results of sysdb_search_with_ts_attr()

Resolves: SSSD#5412
@alexey-tikhonov alexey-tikhonov mentioned this issue Nov 22, 2020
Closed
pbrezina pushed a commit that referenced this issue Nov 23, 2020
@alexey-tikhonov @pbrezina
SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[]
9ace3a7 
This helps to avoid sssd_be segfaults at be_refresh_get_values_ex() due to NULL
ptrs in results of sysdb_search_with_ts_attr()

Resolves: #5412

Reviewed-by: Pavel Březina <pbrezina@redhat.com>
(cherry picked from commit ff24d15)
@pbrezina
Copy link
Member

Pushed PR: #5414

  • master
    • ff24d15 - SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[]
  • sssd-1-16
    • 9ace3a7 - SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[]

@pbrezina pbrezina added the Closed: Fixed Issue was closed as fixed. label Nov 23, 2020
elkoniu pushed a commit to elkoniu/sssd that referenced this issue Feb 28, 2021
@alexey-tikhonov @elkoniu
SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[]
3d7490f 
This helps to avoid sssd_be segfaults at be_refresh_get_values_ex() due to NULL
ptrs in results of sysdb_search_with_ts_attr()

Resolves: SSSD#5412

Reviewed-by: Pavel Březina <pbrezina@redhat.com>
akuster pushed a commit to akuster/sssd that referenced this issue May 18, 2021
@alexey-tikhonov @akuster
SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[]
4d2ae9a 
This helps to avoid sssd_be segfaults at be_refresh_get_values_ex() due to NULL
ptrs in results of sysdb_search_with_ts_attr()

Resolves: SSSD#5412

Reviewed-by: Pavel Březina <pbrezina@redhat.com>
etrunko pushed a commit to etrunko/sssd that referenced this issue Nov 16, 2023
@alexey-tikhonov @etrunko
SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[]
cc5ee7c 
This helps to avoid sssd_be segfaults at be_refresh_get_values_ex() due to NULL
ptrs in results of sysdb_search_with_ts_attr()

Resolves: SSSD#5412

Reviewed-by: Pavel Březina <pbrezina@redhat.com>
(cherry picked from commit ff24d15)
etrunko pushed a commit to etrunko/sssd that referenced this issue Nov 16, 2023
@alexey-tikhonov @etrunko
SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[]
1e65d18 
This helps to avoid sssd_be segfaults at be_refresh_get_values_ex() due to NULL
ptrs in results of sysdb_search_with_ts_attr()

Resolves: SSSD#5412

Reviewed-by: Pavel Březina <pbrezina@redhat.com>
(cherry picked from commit ff24d15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-tikhonov alexey-tikhonov

Labels
Bugzilla Closed: Fixed Issue was closed as fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SYSDB: merge_res_sysdb_attrs() fixed to avoid NULL ptr in msgs[] alexey-tikhonov/sssd
2 participants
@pbrezina @alexey-tikhonov