Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle large service tickets in SSS_GSSAPI_SEC_CTX packets #5572

Closed
wants to merge 6 commits into from
Closed

Handle large service tickets in SSS_GSSAPI_SEC_CTX packets #5572

wants to merge 6 commits into from

Conversation

yrro
Copy link
Contributor

@yrro yrro commented Apr 7, 2021

Fixes #5568

@yrro yrro force-pushed the gss-large-tickets branch 2 times, most recently from 0b235d2 to dace437 Compare April 7, 2021 17:35
@alexey-tikhonov
Copy link
Member

Thank you for the patches. In general looks good to me.

Could you please add Resolves: https://github.com/SSSD/sssd/issues/5568 to the commit message of first patch?

@yrro yrro force-pushed the gss-large-tickets branch 2 times, most recently from 5ca17c3 to f11c1e1 Compare April 7, 2021 19:07
yrro
yrro commented Apr 7, 2021
View reviewed changes
src/responder/common/responder_packet.c Outdated Show resolved Hide resolved
src/responder/common/responder_packet.c Outdated Show resolved Hide resolved
yrro added 4 commits April 9, 2021 09:41
@yrro
responder/common/responder_packet: add debug logging to assist with e…
a452b4b 
…rrors caused by overlarge packets
@yrro
responder/common/responder_packet: further increase packet size for S…
5d818a8 
…SS_GSSAPI_SEC_CTX

Tokens can be 48 KiB in Windows Server 2012. Limiting to 128 KiB
provides extra overhead should that increase in the future.
@yrro
responder/common/responder_packet: remove some unnecessary checks bef…
efa0fe9 
…ore growing packet
@yrro
responder/common/responder_packet: allow packets of max size
9f8cc86
@alexey-tikhonov
Copy link
Member

Thank you, ACK.

@alexey-tikhonov alexey-tikhonov self-assigned this Apr 9, 2021
@pbrezina pbrezina added the Ready to push Ready to push label Apr 12, 2021
@pbrezina
Copy link
Member

Pushed PR: #5572

  • master
    • b87619f - responder/common/responder_packet: allow packets of max size
    • 5c9fa75 - responder/common/responder_packet: remove some unnecessary checks before growing packet
    • 37d3317 - responder/common/responder_packet: further increase packet size for SSS_GSSAPI_SEC_CTX
    • 63f318f - responder/common/responder_packet: add debug logging to assist with errors caused by overlarge packets
    • c6a7628 - responder/common/responder_packet: reduce duplication of code that handles larger-than-normal packets
    • b6efe6b - responder/common/responder_packet: handle large service tickets

@pbrezina pbrezina removed Accepted Ready to push Ready to push labels Apr 12, 2021
@pbrezina pbrezina closed this Apr 12, 2021
@pbrezina pbrezina mentioned this pull request Apr 12, 2021
Closed
@yrro yrro deleted the gss-large-tickets branch April 12, 2021 12:13
@yrro yrro restored the gss-large-tickets branch April 12, 2021 12:13
@yrro yrro deleted the gss-large-tickets branch April 12, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-tikhonov alexey-tikhonov alexey-tikhonov left review comments

Assignees

@alexey-tikhonov alexey-tikhonov

Labels
Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pam_sss_gss.so doesn't work with large kerberos tickets
3 participants
@yrro @alexey-tikhonov @pbrezina