Strip whitespaces in netgroup triple. #568
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
okay to test |
|
ok to test |
|
Just a quick note because the PR did not get any review for three weeks now -- I checked the code when it was submitted and it looks OK after a visual inspection. I was going to write a test to make sure splitting the triples works, but I (and others on our team) were swamped with unexpected urgent work, so I did not have the time to finish the test. So, I'm sorry this PR got stalled, it's on my list to get back to it. Thank you very much for the contribution. |
|
I'm sorry it took me two months to get to the review. I found one minor issue where you left some unused variables after the refactoring and wrote a unit test. Both commits are in my netgrtest branch. If you agree, could you cherry-pick and squash the patch that removes the unused variables? Then I'd push your patch and submit the test separately. |
|
removing variables: jhrozek@a6fd80a |
|
btw I'm setting changes requested to this PR because the unused variables should be squashed. I can do that myself as well if you don't have the time (I hope you didn't get too irritated about the long response time in the meantime..) |
Strip leading and trailing whitespaces from netgroup three-tuple strings to be compatible with nss_ldap.
malyzelenyhnus
force-pushed
the
jc-netgrp-whitespaces
branch
from
e811765
to
8acf25d
Compare
|
Thank you, ack |
|
|
Thank you very much for the contribution and sorry for the huge delay in review. |
Strip leading and trailing whitespaces from netgroup three-tuple
strings to be compatible with nss_ldap.