Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pam_cert_pam_services option #620

Closed
wants to merge 1 commit into from
Closed

Conversation

abbra
Copy link
Contributor

@abbra abbra commented Jul 20, 2018

Allow customizing which PAM services are allowed to perform smartcard
authentication.

Fixes: https://pagure.io/SSSD/sssd/issue/3775

Allow customizing which PAM services are allowed to perform smartcard
authentication.

Fixes: https://pagure.io/SSSD/sssd/issue/3775

Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
@centos-ci
Copy link

Can one of the admins verify this patch?

1 similar comment
@centos-ci
Copy link

Can one of the admins verify this patch?

@fidencio
Copy link
Contributor

ok to test

@fidencio
Copy link
Contributor

@abbra, patch looks good to me.
I'd also provide a scratch-build to Orion in order to be sure it works for him.

In any case, if it's not urgent I'd also like to have either @jhrozek's or @sumit-bose's eyes on this PR.

@jhrozek jhrozek requested a review from sumit-bose July 30, 2018 10:44
@sumit-bose
Copy link
Contributor

Hi Alexander,

thank you for the patch. There is an old patch by @lslebodn which tries to solve the same issue at https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/thread/FQWOBQV6FFCBKZS2EXKIJU74473E7R7Y/

I'd like to ask you if you can use the '+service' '-service' scheme as well because imo it would make the configuration easier to write and read and less error-prone.

bye,
Sumit

@sumit-bose
Copy link
Contributor

@lslebodn created a PR with his old patch at https://pagure.io/SSSD/sssd/pull-request/3799.

@abbra, would you agree that the +- style makes the configuration easier or do you see advantages to always specify the full list?

@abbra
Copy link
Contributor Author

abbra commented Aug 8, 2018

I think +service style is better. Sorry for slow answers, I'm at the conference this week.

@abbra
Copy link
Contributor Author

abbra commented Aug 8, 2018

I'm also fine with @lslebodn patch

@fidencio
Copy link
Contributor

fidencio commented Aug 9, 2018

@sumit-bose, shall we go for @lslebodn's patch instead?
If so, I'd close this PR and push https://pagure.io/SSSD/sssd/pull-request/3799 Tomorrow.

@sumit-bose
Copy link
Contributor

@fidencio, yes, I'm currently reviewing @lslebodn patch.

@fidencio
Copy link
Contributor

@lslebodn's patch has been merged, thus I'm closing this PR.

@fidencio fidencio closed this Aug 13, 2018
@fidencio fidencio added the superseded This PR is superseded in favor if a different one label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
superseded This PR is superseded in favor if a different one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants