Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: housekeeping, test_autofs.py #7466

Closed
wants to merge 1 commit into from
Closed

tests: housekeeping, test_autofs.py #7466

wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Jun 29, 2024 •
edited

  • adding error messages

@danlavu danlavu self-assigned this Jun 29, 2024
@danlavu danlavu changed the title tests: test_autofs.py - adding error messages tests: housekeeping, test_autofs.py Jun 30, 2024
thalman
thalman requested changes Jul 2, 2024
View reviewed changes
src/tests/system/tests/test_autofs.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_autofs.py Outdated Show resolved Hide resolved
@danlavu danlavu force-pushed the tests-housekeeping-test_autofs_py branch from 0637e3e to 71c88d9 Compare July 2, 2024 13:41
@danlavu danlavu requested a review from thalman July 2, 2024 13:42
thalman
thalman approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, ACK

@danlavu danlavu requested a review from thalman July 5, 2024 19:44
@thalman
Copy link
Contributor

thalman commented Jul 8, 2024

CI failures are not connected to the patch. ACK

@danlavu danlavu added the Ready to push Ready to push label Jul 8, 2024
@jakub-vavra-cz jakub-vavra-cz added the backport-to-stable Targets also latest stable branch label Jul 9, 2024
jakub-vavra-cz
jakub-vavra-cz approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-vavra-cz jakub-vavra-cz removed the Ready to push Ready to push label Jul 10, 2024
@jakub-vavra-cz
Copy link
Contributor

Pushed PR: #7466

  • master

  • sssd-2-7

  • sssd-2-8

  • sssd-2-9

    • cc1c0a1 - tests: test_autofs.py - adding error messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

@thalman thalman Awaiting requested review from thalman

Assignees

@thalman thalman

@jakub-vavra-cz jakub-vavra-cz

Labels
backport-to-stable Targets also latest stable branch branch: sssd-2-7 branch: sssd-2-8 Pushed Tests Trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danlavu @thalman @jakub-vavra-cz @andreboscatto