Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mobile | Scanner and QR code improvements #912

Merged
merged 7 commits into from
May 24, 2024
Merged

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented May 15, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Closes #896

  1. What was changed?
  1. Replaces the QR code image in the flyout with a button as it does not fit on smaller screens. Tapping this brings up a larger version of the QR code in a popup with the screen brightness set to max and increased contrast to make scanning easier. This also tidies up AppShell a bit by moving the footer into a new FlyoutFooter control.
  2. Fixes an issue where the camera indicator never goes away on iOS by ensuring the scanner is properly disposed when closed.

Figure: Tapping your QR code brings up a larger version with better contrast and the screen brightness increased

Figure: New button to replace the QR code, which now works on smaller screens (screenshot taken from iPhone SE)

  1. Did you do pair or mob programming?

No.

@zacharykeeping zacharykeeping marked this pull request as ready for review May 15, 2024 01:47
@zacharykeeping zacharykeeping changed the title 🐛 Mobile | Scanner improvements 🐛 Mobile | Scanner and QR code improvements May 16, 2024
Text=" "
IsVisible="{OnPlatform Android='False', iOS='True'}"/>
</Grid>
<controls:FlyoutFooter />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 👍

Copy link
Member

@AntPolkanov AntPolkanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zacharykeeping zacharykeeping merged commit c0cf9e8 into main May 24, 2024
6 checks passed
@zacharykeeping zacharykeeping deleted the scanner-fix branch May 24, 2024 02:10
AntPolkanov added a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Profile picture - Indicates recording on iPad Mini
2 participants