Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Mobile | Reverting a change from PR #912, issue #896 #949

Merged
merged 1 commit into from
Jun 13, 2024
Merged

馃悰 Mobile | Reverting a change from PR #912, issue #896 #949

merged 1 commit into from
Jun 13, 2024

Conversation

AntPolkanov
Copy link
Member

cc: @zacharykeeping

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)
  1. Open the scanner
  2. Close it
  3. Open the scanner again

Result: the camera freezes (see the video below)

  1. What was changed?

鉁忥笍 Removed a line which was disconnecting a Handler.

  1. Did you do pair or mob programming?

鉁忥笍 No

RPReplay_Final1718281903.MP4

matt-goldman-ssw
matt-goldman-ssw approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@matt-goldman-ssw matt-goldman-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntPolkanov AntPolkanov merged commit 9c16e8c into main Jun 13, 2024
6 checks passed
@AntPolkanov AntPolkanov deleted the fix branch June 13, 2024 12:47
@AntPolkanov AntPolkanov mentioned this pull request Jun 13, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-goldman-ssw matt-goldman-ssw matt-goldman-ssw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AntPolkanov @matt-goldman-ssw