Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ ✨ Create Why Blazor is great Rule #8855

Merged
merged 4 commits into from
Jul 9, 2024
Merged

XS✔ ◾ ✨ Create Why Blazor is great Rule #8855

merged 4 commits into from
Jul 9, 2024

Conversation

MattParkerDev
Copy link
Member

@MattParkerDev MattParkerDev commented Jul 9, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Email subject: Rules to Better Angular and Blazor

  1. What was changed?

New Rule

  1. Did you do pair or mob programming (list names)?

No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 58
Total 58

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title ✨ Create Why Blazor is great Rule XS✔ ◾ ✨ Create Why Blazor is great Rule Jul 9, 2024
bradystroud
bradystroud approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
In the future we could add some negatives, but i think this is fine for now

@bradystroud bradystroud merged commit b3d3a1a into main Jul 9, 2024
5 of 6 checks passed
@bradystroud bradystroud deleted the blazor-great branch July 9, 2024 01:49
@github-actions github-actions bot restored the blazor-great branch July 9, 2024 01:49
@bradystroud bradystroud deleted the blazor-great branch July 9, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradystroud bradystroud bradystroud approved these changes

Assignees
No one assigned
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MattParkerDev @bradystroud