[WIP] Capcha Support

[Rover656]

Closes issues

• Closes Captcha #1764

Changes

• Adds Capcha Support

Change details

Using changes discussed in #1764 (It's a big conversation)

Other informations

It may not work, looking for people to test it.

[ST-Apps]

I'm seeing a lot of unrelated changes like this line, can you please just add what's needed for captcha to work?

[Rover656]

Sorry, I will clean the code up tomorrow, I had multiple branches in the same folder

[Rover656]

Is fixed

[ST-Apps]

Please fix code format.

[Rover656]

This is part of the unrelated code, will fix this problem tomorrow
EDIT: Oh, I see what you mean

[Rover656]

Is fixed

[ST-Apps]

I don't think that this check is needed, if url starts with "unity:" then you can just take a substring starting from "unity:".Length. The else should be for the outer if.

[Rover656]

OK, I will fix this tomorrow along with the. Csproj file

[Rover656]

Is fixed

[ghost]

@Rover656 Thanks for your effort. I have the code running in my phone. Just need to trigger captcha somehow.
Maybe some speeding would do the trick :)

[Rover656]

@ST-Apps The code is all fixed 😄

[WallyCZ]

CheckChallenge is already called with login in Login.cs:64 - you should use this response and don't call it again separately

[Rover656]

@WallyCZ How do you mean?

[Rover656]

@WallyCZ oh ok, how would we adapt this to use in the current situation?

[Rover656]

so it would look like this?:

    private async Task SetServer()
    {

        var serverRequest = RequestBuilder.GetInitialRequestEnvelope(
            new Request
            {
                RequestType = RequestType.GetPlayer,
                RequestMessage = new GetPlayerMessage().ToByteString()
            },
            new Request
            {
                RequestType = RequestType.CheckChallenge,
                RequestMessage = new CheckChallengeMessage().ToByteString()
            }
        );

        var serverResponse = await PostProto<Request>(Resources.RpcUrl, serverRequest);

        if(serverRequest.StatusCode == (int) StatusCode.AccessDenied)
        {
            throw new AccountLockedException();
        }

        if(serverResponse.ShowChallenge)
        {
            // Captcha is shown in checkChallengeResponse.ChallengeUrl
            Logger.Write($"ChallengeURL: {checkChallengeResponse.ChallengeUrl}");
            // breakpoint here to manually resolve Captcha in a browser
            // after that set token to str variable from browser (see screenshot)
            Logger.Write($"Pause");

            //GOTO THE REQUIRED PAGE
            BootStrapper.Current.NavigationService.Navigate(typeof(ChallengePage), checkChallengeResponse.ChallengeUrl);

            //await VerifyChallenge(token);
        }

        if (serverResponse.AuthTicket == null)
        {
            Client.AccessToken = null;
            throw new AccessTokenExpiredException();
        }

        Client.AccessToken.AuthTicket = serverResponse.AuthTicket;

        if (serverResponse.StatusCode == (int)StatusCode.Redirect)
        {
            Client.ApiUrl = serverResponse.ApiUrl;
        }
    }

[WallyCZ]

You should not call UI elements (Navigate) from API, so you can trigger in API some event or store ChallengeResponse object to be able to read it from client after login. But you found right place to hook it. If you want help just let me know

[Rover656]

Yea, could you help me please @WallyCZ i am not sure how this api works, i'm better with webviews and client sided programming

[WallyCZ]

I will on look it after work. Meantime please check if _client attribute is properly initialized in your .xaml.cs class.

[Rover656]

@WallyCZ no, i don't think so, i will look into it
EDIT: How would one do that?
EDIT: Just got some help, yes it is initialized:
private static Client _client;

[WallyCZ]

This will not work this way. Have you tested it? It will crash when first call _client. occurs. There is already one (properly initialized) static instance inside GameClient, so you must use this (through creating new method in GameClient). This is what you have already done but it seems you are not using it.

[Rover656]

Could you try to repair this?

[WallyCZ]

ok

[ghost]

Just thinking... If the captcha is checked only when the user logs in how will he know in the middle of the game that he has been hit by captcha?
It's true that then you won't see mons or stops anymore, but so does exceeding the speed limit. How to tell the difference?
Edit: how does the official client behave to captcha?

[WallyCZ]

Request for captcha can virtually come with every response in original client. I'll try to do something similar, but this RocketAPI was not designed to fit these requirements...

[ghost]

Got an account with pending captcha and having the following error with it:

[WallyCZ]

@Rover656 Sent PR https://github.com/Rover656/PoGo-UWP/pull/3 to your repo so please merge it ;)

[Rover656]

Ok

[Rover656]

All ready for merge

[WallyCZ]

Sry, forgot to add this line to GameClient.cs:378:

apiFailureStrategy.OnFailureToggleUpdateTimer += ToggleUpdateTimer;

so it should look like this:

            var apiFailureStrategy = new ApiFailureStrategy(_client);
            _client.ApiFailure = apiFailureStrategy;
            // Register to AccessTokenChanged
            apiFailureStrategy.OnAccessTokenUpdated += (s, e) => SaveAccessToken();
            apiFailureStrategy.OnFailureToggleUpdateTimer += ToggleUpdateTimer;
        }

@Rover656 Could you do it? Thanks

[Rover656]

@WallyCZ all fixed

[ghost]

Tested, works nicely.

[Rover656]

@BadiBasso Great. @ST-Apps, it is ready for merge