-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #262: Moved from Newtonsoft.Json to System.Text.Json #324
base: development
Are you sure you want to change the base?
Fix #262: Moved from Newtonsoft.Json to System.Text.Json #324
Conversation
I think that the issue found by SQ should be discarded and non-relevant with the context of the code |
public override void Write(Utf8JsonWriter writer, PostOperation value, JsonSerializerOptions options) | ||
{ | ||
writer.WriteStartObject(); | ||
writer.WriteStartArray("_delete"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing "u8"
{ | ||
domainOfExpertise.Name = jObject["name"].ToObject<string>(); | ||
if(nameProperty.ValueKind == JsonValueKind.Null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets log at Trace level
<PackageTags>CDP COMET ECSS-E-TM-10-25 JSON</PackageTags> | ||
<PackageLicenseExpression>LGPL-3.0-only</PackageLicenseExpression> | ||
<PackageReleaseNotes> | ||
[BUMP] To CDP4Common 26.6.0 | ||
</PackageReleaseNotes> | ||
<PackageReadmeFile>README.md</PackageReadmeFile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please restore the README.md
@@ -0,0 +1,20 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to add some docs somewhere what the purpose is and how to use it
emailAddress.ModifiedOn = jObject["modifiedOn"].ToObject<DateTime>(); | ||
if(modifiedOnProperty.ValueKind == JsonValueKind.Null) | ||
{ | ||
Logger.Trace("The non-nullabale modifiedOn property of the emailAddress {id} is null", emailAddress.Iid); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
emailAddress.ThingPreference = jObject["thingPreference"].ToObject<string>(); | ||
if(thingPreferenceProperty.ValueKind == JsonValueKind.Null) | ||
{ | ||
Logger.Trace("The non-nullabale thingPreference property of the emailAddress {id} is null", emailAddress.Iid); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
emailAddress.Value = jObject["value"].ToObject<string>(); | ||
if(valueProperty.ValueKind == JsonValueKind.Null) | ||
{ | ||
Logger.Trace("The non-nullabale value property of the emailAddress {id} is null", emailAddress.Iid); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
emailAddress.VcardType = jObject["vcardType"].ToObject<VcardEmailAddressKind>(); | ||
if(vcardTypeProperty.ValueKind == JsonValueKind.Null) | ||
{ | ||
Logger.Trace("The non-nullabale vcardType property of the emailAddress {id} is null", emailAddress.Iid); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
Private data returned by
access to local variable emailAddress
/// Initializes a new <see cref="PostOperationJsonConverter" /> instance. | ||
/// </summary> | ||
/// <param name="ignoreCopyProperty">Asserts that the <see cref="PostOperation.Copy"/> have to be ignored</param> | ||
public PostOperationJsonConverter(bool ignoreCopyProperty = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default should be true, since this is special for COMET and not supported by version 1,0.0 of 10-25
Quality Gate passedIssues Measures |
Prerequisites
Description
Fix #262
BREAKING CHANGES :