Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] (de)serialization of AlternativeID; fixes #54 #55

Merged

Conversation

samatstariongroup
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the ReqIFSharp code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

refactor serialization and deserialization of ALTERNATIVE-ID as per XML schema. The implementation still supports the (incorrect) deserialization as well, since sample data found on the internet provides incorrect data sets.

[Verify] that generated reqif doc can be deserialized with validation
Copy link

sonarcloud bot commented May 14, 2024

@samatstariongroup samatstariongroup merged commit e1ce195 into development May 14, 2024
6 checks passed
@samatstariongroup samatstariongroup deleted the GH54-fix-serialization-of-alternative-id branch May 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants