Refactor scaling component apply function #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in metadata & add sample plans
… & update k8s json patch resource renamed
…point', 'ca_cert' params were optional & update k8s deployment sample plans
…the-scaling-component
pueding
approved these changes
Mar 8, 2024
| @@ -681,6 +685,12 @@ mod test { | |||
| use data_layer::ScalingComponentDefinition; | |||
| use std::collections::HashMap; | |||
|
|
|||
| async fn get_rquickjs_context() -> rquickjs::AsyncContext { | |||
There was a problem hiding this comment.
define "get_rquickjs_context" once and reuse it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Which issue/s this PR fixes (#)
#260
How Has This Been Tested?