Variadic templates support for actions #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o/ |
|
Would it be now possible to unify the |
Yes, and it's also possible to simplify actions implementations much further still. That will come at a later PR |
| >::type | ||
| > | ||
| >::type | ||
| lcos::future< |
There was a problem hiding this comment.
Why did you remove the enable_if here?
There was a problem hiding this comment.
Here and in a few other places. Because they are not disambiguating anything, and the kind of errors this gives when misused is the worst.
|
LGTM |
K-ballo
added a commit
that referenced
this pull request
Dec 22, 2014
Variadic templates support for actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces variadic templates support for actions, including a number of refactions and simplifications to make it possible.
actionwas renamed tobasic_action, and takes a function signature instead of a result and a tuple of arguments.plain_action/plain_result_action->plain_action).plain_action->action).