Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variadic templates support for actions #1332

Merged
merged 7 commits into from Dec 22, 2014

Conversation

Projects
None yet
3 participants
@K-ballo
Copy link
Member

commented Dec 18, 2014

This PR introduces variadic templates support for actions, including a number of refactions and simplifications to make it possible.

  • The basic action was renamed to basic_action, and takes a function signature instead of a result and a tuple of arguments.
  • Actions returning void and actions returning a result were unified (plain_action/plain_result_action -> plain_action).
  • Plain actions and component actions were unified (plain_action -> action).
@hkaiser

This comment has been minimized.

Copy link
Member

commented Dec 18, 2014

\o/

@hkaiser

This comment has been minimized.

Copy link
Member

commented Dec 19, 2014

Would it be now possible to unify the HPX_FOO_ACTION macros? I'd very much like to have to write HPX_ACTION only (instead of HPX_PLAIN_ACTION, etc.).

@K-ballo

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2014

Would it be now possible to unify the HPX_FOO_ACTION macros? I'd very much like to have to write HPX_ACTION only (instead of HPX_PLAIN_ACTION, etc.).

Yes, and it's also possible to simplify actions implementations much further still. That will come at a later PR

>::type
>
>::type
lcos::future<

This comment has been minimized.

Copy link
@sithhell

sithhell Dec 19, 2014

Member

Why did you remove the enable_if here?

This comment has been minimized.

Copy link
@K-ballo

K-ballo Dec 19, 2014

Author Member

Here and in a few other places. Because they are not disambiguating anything, and the kind of errors this gives when misused is the worst.

@@ -3,156 +3,69 @@
// Distributed under the Boost Software License, Version 1.0. (See accompanying

This comment has been minimized.

Copy link
@sithhell

sithhell Dec 19, 2014

Member

Can't we get rid of that file now and have the operators be defined directly inline of the action header?

This comment has been minimized.

Copy link
@K-ballo

K-ballo Dec 19, 2014

Author Member

Yes, that could be done. I'll add that to the list of further refactions to actions.

@K-ballo K-ballo force-pushed the K-ballo:actions branch from f76cc9a to 937ce9e Dec 19, 2014

@hkaiser

This comment has been minimized.

Copy link
Member

commented Dec 21, 2014

LGTM

K-ballo added a commit that referenced this pull request Dec 22, 2014

Merge pull request #1332 from K-ballo/actions
Variadic templates support for actions

@K-ballo K-ballo merged commit c182b3f into STEllAR-GROUP:master Dec 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.