Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require support for nullptr #2213

Merged
merged 2 commits into from Jun 14, 2016

Conversation

Projects
None yet
3 participants
@mcopik
Copy link
Contributor

commented Jun 13, 2016

HPX is already using nullptr, mostly in compute. There is a test for nullptr detection, but neither it is required nor a replacement macro is provided.

We decided to require nullptr for HPX; if all compilers can handle current code, then an additional macro should not be necessary.

@K-ballo

This comment has been minimized.

Copy link
Member

commented Jun 13, 2016

Rather than adding a new hpx_check_for_cxx11_nullptr, modify the one above in that file

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jun 13, 2016

LGTM, thanks.

@K-ballo

This comment has been minimized.

Copy link
Member

commented Jun 13, 2016

Should we have inspect flag NULLs now?

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jun 13, 2016

Should we have inspect flag NULL s now?

Good point! I created a ticket for that (#2214)

@hkaiser hkaiser merged commit cb3ab01 into STEllAR-GROUP:master Jun 14, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.