Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue when compiling components with hpxcxx #2225

Merged
merged 1 commit into from Jun 23, 2016

Conversation

Projects
None yet
3 participants
@stevenrbrandt
Copy link
Member

commented Jun 22, 2016

hpxcxx uses an inappropriate HPX_COMPONENT_NAME (i.e. the name of the output so file). This leads to numerous non-intuitive compilation errors. This change fixes that. Also, invoking the shell with $() in some places and in others is inconsistent. Here I settle on use of.

@hkaiser hkaiser added this to the 0.9.12 milestone Jun 22, 2016

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jun 22, 2016

LGTM, thanks!

@sithhell sithhell merged commit e03d9b2 into master Jun 23, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@sithhell sithhell deleted the fix_hpxcxx branch Jun 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.