Continuations #2383
Merged
Continuations #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 13, 2016 10:32
This patch gets rid of the need for std::unique_ptr<hpx::actions::continuation>. This is made possible by defining special transfer actions that carry a typed continuation along. This has the effect of fewer memory allocations as well as no serialization over a polymorphic base pointer. In addition, this patch cleans up headers and removes code, where possible to their own TU to reduce binary sizes.
Conflicts: hpx/lcos/base_lco_with_value.hpp
Conflicts: src/pre_main.cpp
Conflicts: hpx/runtime/parcelset/parcel.hpp src/runtime/parcelset/parcel.cpp
hkaiser
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch gets rid of
hpx::actions::continuationto not be used as a polymorphic base class. This saves dynamic allocations when invoking async actions.Another side effect of this patch is the reduction of compile times as well as a reduction of binary size.