-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs and improve that about HPX_HAVE_CXX11_AUTO_RETURN_VALUE of CMake. #2821
Fix bugs and improve that about HPX_HAVE_CXX11_AUTO_RETURN_VALUE of CMake. #2821
Conversation
When uses C++11, HPX_CXX11_AUTO_RETURN_VALUE_DEFAULT must be OFF.
cb18e0a
to
a49a7df
Compare
a49a7df
to
f206f20
Compare
I think it should be
The feature in question is a C++11 feature. C++11 allows for using |
@hkaiser Does the feature is a C++11 feature really?? But, I got compile errors related to auto return value with C++11... (https://gist.github.com/taeguk/a9a37590471f0c30a706ca6aea0a392f) |
@taeguk, you're right - sorry for the confusion on my end. So this is a C++14 facility after all ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
In this case we might want an overridable configure time test to detect whether this setting should on or off. We had one in 8599ce3 |
@gentryx Do you mean adding feature tests for auto return value? |
Wait. What's the problem with CUDA? |
We run the feature tests not for NVCC but for the compiler used by NVCC to generate the code. NVCC itself is just a preprocessor which generates C code from the C++ input. |
@taeguk Yes, that's what I meant. |
This is related to #2720.
@hkaiser @gentryx Can you review this?
Added later)