Fix libfabric tcp #3353
Merged
Fix libfabric tcp #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the TCP parcelport with two localities on the same node caused problems because the libfabric address vector lookup was using only the ip address. This fix adds the port number to the map key so that multiple localities on the same node can be supported. Moving to an index based lookup of locality->fabric address would be the next obvious step.
When using the GNI provider and booting with PMI the endpoint is enabled via another code path. This fixes the libfabric PP with TCP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3352
Allows nodes to send messages using libfabric over TCP
Does not yet fix the boot/initialization, this still uses the default TCP boost:asio parcelport