Making hpx::util::tuple<Ts...> and std::tuple<Ts...> convertible #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sithhell
force-pushed
the
fixing_1403
branch
2 times, most recently
from
6c54b6a
to
5bdfce8
Compare
hkaiser
reviewed
Jul 5, 2019
hkaiser
reviewed
Jul 5, 2019
hkaiser
reviewed
Jul 5, 2019
hkaiser
reviewed
Jul 5, 2019
K-ballo
reviewed
Jul 5, 2019
|
@sithhell would you have time to look at the build failures? |
sithhell
force-pushed
the
fixing_1403
branch
2 times, most recently
from
94d6844
to
ae99516
Compare
sithhell
force-pushed
the
fixing_1403
branch
from
ae99516
to
e917d1c
Compare
|
This should be ready to go now. |
sithhell
force-pushed
the
fixing_1403
branch
2 times, most recently
from
81791a5
to
dc13ee4
Compare
hkaiser
reviewed
Sep 17, 2019
hkaiser
reviewed
Sep 17, 2019
sithhell
force-pushed
the
fixing_1403
branch
2 times, most recently
from
d08a04d
to
9144237
Compare
hkaiser
reviewed
Sep 18, 2019
hkaiser
reviewed
Sep 18, 2019
hkaiser
reviewed
Sep 18, 2019
hkaiser
reviewed
Sep 18, 2019
hkaiser
force-pushed
the
fixing_1403
branch
2 times, most recently
from
9ec5b73
to
cdf91a1
Compare
Fixes #1403 by allowing the use of hpx::util::get with std::tuple and std::get with hpx::util::tuple::get. Same goes for the utilities tuple_size and tuple_element. An additional conversion operator from hpx::util::tuple<Ts..> to std::tuple<Ts..> has been added to make the two types interchangable. Flyby: Making the datastructures unit test only depend on itself and hpx_testing: Adding hpx/traits/is_tuple_like.hpp
…ADL barrier - adding option to disable the integration of hpx::tuple with std::tuple - flyby: fixing default value for HPX_FILESYSTEM_WITH_BOOST_FILESYSTEM_COMPATIBILITY
hkaiser
force-pushed
the
fixing_1403
branch
from
cdf91a1
to
4f035dc
Compare
hkaiser
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
LGTM now, thanks! See also @sithhell comments here: http://irclog.cct.lsu.edu/ste~b~~b~ar/2019-09-25#1569431379-1569431420;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1403 by allowing the use of hpx::util::get with std::tuple and
std::get with hpx::util::tuple::get. Same goes for the utilities
tuple_size and tuple_element.
An additional conversion operator from hpx::util::tuple<Ts..> to
std::tuple<Ts..> has been added to make the two types interchangable.