Fix clang-tidy step on CircleCI #3978
Conversation
msimberg
force-pushed
the
clang-tidy-circleci
branch
from
a9e28f9
to
6f91f74
Compare
|
TBH, I think it would be best to use the |
|
Good idea. I didn't realize there was such an option to CMake. I'll update it to use that instead. Since it'll check all files I'll need some time to fix errors that have appeared since it went out of business... |
|
Does |
|
This will run it on all targets, so no need for a full clone. It's potentially a bit slower to do it like this (haven't timed it) but gets rid of the additional script. |
msimberg
force-pushed
the
clang-tidy-circleci
branch
from
c1540dd
to
57543fe
Compare
| @@ -444,7 +444,7 @@ namespace hpx { namespace lcos | |||
|
|
|||
| return all_reduce( | |||
| hpx::find_from_basename(std::move(name), root_site), | |||
| std::move(local_result), std::forward<F>(op), this_site); | |||
| std::forward(local_result), std::forward<F>(op), this_site); | |||
There was a problem hiding this comment.
@hkaiser could you please check that the move here and in all_to_all.hpp weren't intentional?
There was a problem hiding this comment.
The forward looks like the right thing to use. Thanks for fixing this!
msimberg
force-pushed
the
clang-tidy-circleci
branch
3 times, most recently
from
cb6305b
to
263727d
Compare
msimberg
force-pushed
the
clang-tidy-circleci
branch
from
263727d
to
09b89b5
Compare
Any background context you want to provide?
The clang-tidy checks have been disabled (unintentionally) on CircleCI since I changed it to do use a shallow clone. We still need the shallow clone to avoid copying the whole repo between steps, but I've changed it to do a full clone just for the clang-tidy step.