Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make counters in coroutines optional #4089

Merged
merged 4 commits into from
Sep 16, 2019

Conversation

msimberg
Copy link
Contributor

Makes the counters optional and turns them off by default. Saves us some cache misses when creating and rebinding threads. It makes a small but noticeable difference in the future_overheads benchmark.

CMakeLists.txt Outdated Show resolved Hide resolved
hkaiser
hkaiser previously approved these changes Sep 11, 2019
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@msimberg msimberg merged commit 2f466f6 into STEllAR-GROUP:master Sep 16, 2019
@msimberg msimberg deleted the optional-coroutines-counters branch September 16, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants