Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for making exceptions less noisy #4552

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Apr 23, 2020

Adds the option hpx.exception_verbosity. It currently takes three values:

  • 0: prints filename, line, function name, and the exception string
  • 1: prints everything except the build configuration and environment variables
  • 2: prints everything

I'm not sure if they need to be shifted to have 0 mean no output, but I don't see that being useful for anyone. We could also use names (like minimal, reduced, full), but using numbers for the level is similar to what we do with logging.

Flyby: fix reading of ini files from HOME and PWD.

To do:

  • documentation

The files in HOME and PWD were not found correctly. When appending "/.hpx.ini"
to a path with / the lhs is replaced, not extended, because of the leading
slash.
@msimberg msimberg marked this pull request as ready for review April 24, 2020 09:05
hkaiser
hkaiser previously approved these changes Apr 24, 2020
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@msimberg
Copy link
Contributor Author

I applied the verbosity setting also in the termination handler now.

@msimberg msimberg merged commit 54ed1bb into STEllAR-GROUP:master Apr 28, 2020
@msimberg msimberg deleted the exception-verbosity branch April 28, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants