Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on various Boost headers #4843

Merged
merged 10 commits into from
Jul 23, 2020
Merged

Remove dependency on various Boost headers #4843

merged 10 commits into from
Jul 23, 2020

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jul 20, 2020

No description provided.

@hkaiser hkaiser added this to the 1.5.0 milestone Jul 20, 2020
@biddisco biddisco mentioned this pull request Jul 20, 2020
Open
@hkaiser hkaiser changed the title Remove dependency on Boost.Assign Remove dependency on various Boost headers Jul 20, 2020
msimberg
msimberg previously approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

biddisco
biddisco previously approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msimberg
Copy link
Contributor

retest

@msimberg msimberg merged commit dbc75f5 into master Jul 23, 2020
@msimberg msimberg deleted the boost_assign branch July 23, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg left review comments

@biddisco biddisco biddisco left review comments

@aurianer aurianer Awaiting requested review from aurianer

Assignees
No one assigned
Labels
type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hkaiser @msimberg @biddisco