Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm to 4.0.1 on Rostam #5215

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Mar 2, 2021

I compiled fine locally on Rostam, let's see what CI says

@aurianer aurianer added this to the 1.7.0 milestone Mar 2, 2021
hkaiser
hkaiser previously approved these changes Mar 2, 2021
@aurianer
Copy link
Contributor Author

aurianer commented Mar 5, 2021

retest

@aurianer
Copy link
Contributor Author

aurianer commented Mar 5, 2021

There is still one failing test for hipcc-debug but I think we can merge this since it improves a lot master (cf the build failures)

@msimberg
Copy link
Contributor

msimberg commented Mar 8, 2021

retest lsu

@msimberg
Copy link
Contributor

msimberg commented Mar 9, 2021

There was a temporary timeout on one of the CUDA/HIP tests on this PR that did not repeat when this was retriggered. Let's go ahead with this since neither @aurianer or I could reproduce it, but let's keep an eye out for timeouts like that on master. Thanks @aurianer for updating this!

@msimberg msimberg merged commit 44b57c9 into STEllAR-GROUP:master Mar 9, 2021
@aurianer aurianer deleted the adapt_to_rocm_4_0_1 branch March 11, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants