Move algorithms to tag_fallback_invoke #5287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toktarev
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
|
Can one of the admins verify this patch? |
|
@toktarev any reason you closed this PR? |
|
@hkaiser I am sorry, I see some conflict with master |
|
I am sorry again for this confusion (I see that you've made some work with labels here). |
|
Feel free to leave it open. Just rebase against master, that should take care of the conflicts. |
|
ReOpen option is disabled here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Move algorithms to tag_fallback_invoke
Any background context you want to provide?
Issue: #5204