Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow splitting of futures holding std::tuple #5289

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

severinstrobl
Copy link
Contributor

Analogous to the case of std::pair, it should be possible to split a hpx::future<std::tuple<Ts...>> into std::tuple<hpx::future<Ts>...>.

@jenkins-cscs
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work even if HPX_DATASTRUCTURES_WITH_ADAPT_STD_TUPLE=Off? Our support for hpx::get supporting std::tuple relies on having this enabled (see for instance https://github.com/STEllAR-GROUP/hpx/blob/master/libs/core/datastructures/include/hpx/datastructures/tuple.hpp#L107-L125)

@severinstrobl
Copy link
Contributor Author

Ah, completely missed that part. So would wrapping the respective sections using #if defined()/#endif be acceptable or is there a more elegant solution that would somehow allow the conversion between the tuple types (if enabled)?

@hkaiser
Copy link
Member

hkaiser commented Apr 9, 2021

Ah, completely missed that part. So would wrapping the respective sections using #if defined()/#endif be acceptable or is there a more elegant solution that would somehow allow the conversion between the tuple types (if enabled)?

That would be perfectly acceptable, thanks!

Analogous to the case of std::pair, it should be possible to split a
hpx::future<std::tuple<Ts...>> into std::tuple<hpx::future<Ts>...>.
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Apr 10, 2021

retest

@severinstrobl
Copy link
Contributor Author

As far as I can tell, the failed CI jobs are unrelated to the changes introduced here, but maybe an admin can have a look?

@msimberg
Copy link
Contributor

As far as I can tell, the failed CI jobs are unrelated to the changes introduced here, but maybe an admin can have a look?

This looks good, the remaining failures are unrelated to your changes. Thanks!

@msimberg msimberg merged commit 993cb90 into STEllAR-GROUP:master Apr 13, 2021
@severinstrobl severinstrobl deleted the std_tuple_split_future branch April 13, 2021 09:19
@msimberg msimberg mentioned this pull request Apr 28, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants