-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow splitting of futures holding std::tuple #5289
Allow splitting of futures holding std::tuple #5289
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work even if HPX_DATASTRUCTURES_WITH_ADAPT_STD_TUPLE=Off
? Our support for hpx::get
supporting std::tuple
relies on having this enabled (see for instance https://github.com/STEllAR-GROUP/hpx/blob/master/libs/core/datastructures/include/hpx/datastructures/tuple.hpp#L107-L125)
Ah, completely missed that part. So would wrapping the respective sections using |
That would be perfectly acceptable, thanks! |
6cd0446
to
ef755f6
Compare
Analogous to the case of std::pair, it should be possible to split a hpx::future<std::tuple<Ts...>> into std::tuple<hpx::future<Ts>...>.
ef755f6
to
f3b4b43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
retest |
As far as I can tell, the failed CI jobs are unrelated to the changes introduced here, but maybe an admin can have a look? |
This looks good, the remaining failures are unrelated to your changes. Thanks! |
Analogous to the case of std::pair, it should be possible to split a
hpx::future<std::tuple<Ts...>>
intostd::tuple<hpx::future<Ts>...>
.