Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt lexicographical_compare to C++20 #5350

Merged
merged 4 commits into from May 29, 2021

Conversation

@Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented May 23, 2021

Adapted lexicographical_compare to C++ 20 and added container overloads. (range and sentinel)

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668

@jenkins-cscs
Copy link
Collaborator

@jenkins-cscs jenkins-cscs commented May 23, 2021

Can one of the admins verify this patch?

@hkaiser
Copy link
Member

@hkaiser hkaiser commented May 23, 2021

add to whitelist

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_lex_compare branch from 3022327 to 42ab176 May 24, 2021
@Jedi18 Jedi18 force-pushed the Jedi18:adapt_lex_compare branch from 45b700e to 15fe1a0 May 26, 2021
@Jedi18
Copy link
Contributor Author

@Jedi18 Jedi18 commented May 27, 2021

@hkaiser Sure ok done, sorry for the delay in fixing that

@hkaiser
Copy link
Member

@hkaiser hkaiser commented May 27, 2021

@Jedi18 please note that with #5348 we will rename our tag_invoke facilities. That might affect your work. Please have an eye out for this.

Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@hkaiser hkaiser added this to the 1.7.0 milestone May 28, 2021
@hkaiser hkaiser merged commit 98360b8 into STEllAR-GROUP:master May 29, 2021
27 of 32 checks passed
27 of 32 checks passed
@github-actions
build build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@circleci-checks
build-and-test Workflow: build-and-test
Details
@jenkins-cscs
jenkins/cscs Build finished.
Details
@msimberg
jenkins/cscs/clang-newest Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-cuda-11-release Jenkins
Details
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
@msimberg
jenkins/cscs/clang-10 Jenkins
Details
@msimberg
jenkins/cscs/clang-8 Jenkins
Details
@msimberg
jenkins/cscs/clang-9 Jenkins
Details
@msimberg
jenkins/cscs/clang-apex Jenkins
Details
@msimberg
jenkins/cscs/clang-cuda Jenkins
Details
@msimberg
jenkins/cscs/clang-oldest Jenkins
Details
@msimberg
jenkins/cscs/gcc-10 Jenkins
Details
@msimberg
jenkins/cscs/gcc-cuda Jenkins
Details
@msimberg
jenkins/cscs/gcc-newest Jenkins
Details
@msimberg
jenkins/cscs/gcc-oldest Jenkins
Details
@msimberg
jenkins/cscs/icc Jenkins
Details
@msimberg
jenkins/lsu/clang-9-debug Jenkins
Details
@msimberg
jenkins/lsu/clang-9-release Jenkins
Details
@msimberg
jenkins/lsu/gcc-8-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-8-release Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-cuda-11-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-release Jenkins
Details
@msimberg
jenkins/lsu/hipcc-debug Jenkins
Details
@msimberg
jenkins/lsu/hipcc-release Jenkins
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants