Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt lexicographical_compare to C++20 #5350

merged 4 commits into from May 29, 2021


Copy link

@Jedi18 Jedi18 commented May 23, 2021

Adapted lexicographical_compare to C++ 20 and added container overloads. (range and sentinel)

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668

Copy link

jenkins-cscs commented May 23, 2021

Can one of the admins verify this patch?

Copy link

hkaiser commented May 23, 2021

add to whitelist

Copy link

hkaiser commented May 26, 2021

Copy link
Contributor Author

Jedi18 commented May 27, 2021

@hkaiser Sure ok done, sorry for the delay in fixing that

Copy link

hkaiser commented May 27, 2021

@Jedi18 please note that with #5348 we will rename our tag_invoke facilities. That might affect your work. Please have an eye out for this.

Copy link

@hkaiser hkaiser left a comment

LGTM, thanks!

@hkaiser hkaiser added this to the 1.7.0 milestone May 28, 2021
@hkaiser hkaiser merged commit 98360b8 into STEllAR-GROUP:master May 29, 2021
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants