-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt lexicographical_compare to C++20 #5350
Conversation
Can one of the admins verify this patch? |
add to whitelist |
…fixed sentinel tests
@Jedi18 The newly added test fails compiling: https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/7708/workflows/3673147f-437e-43bc-9448-64f158db2bc2/jobs/251639/steps. Could you please have a look? |
@hkaiser Sure ok done, sorry for the delay in fixing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Adapted lexicographical_compare to C++ 20 and added container overloads. (range and sentinel)
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668