Remove and clean up fallback sender implementations #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
added
type: cleanup
category: senders/receivers
hkaiser
previously approved these changes
Jul 16, 2021
msimberg
force-pushed
the
executor-scheduler-cleanup
branch
from
9036178
to
00a243b
Compare
|
I think this should be ready to go now, but I'd like to give #5283 priority to be merged first. |
msimberg
changed the title
msimberg
force-pushed
the
executor-scheduler-cleanup
branch
2 times, most recently
from
5ec8723
to
451a9c4
Compare
msimberg
force-pushed
the
executor-scheduler-cleanup
branch
from
451a9c4
to
797f601
Compare
|
retest cscs |
Merged
Remove fallbacks that are removed in P2300 that were still there in later revisions of P0443 (e.g. 14). Specifically: - completely removes submit - makes execute a "plain" algorithm, i.e. it does not have a fallback using submit, it only dispatches through tag_dispatch overloads - removes the fallback of connect using as_operation etc. - removes the fallback of schedule using as_sender, connect, etc.
msimberg
force-pushed
the
executor-scheduler-cleanup
branch
from
797f601
to
602de55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove fallbacks that are removed in P2300 that were still there in later revisions of P0443 (e.g. 14). Specifically:
submitsubmit, it only dispatches throughtag_dispatchoverloadsconnectusingas_operationetc.as_sender,connect, etc.