Remove a few deprecated and unused CMake options #5574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
requested review from
aurianer,
biddisco and
hkaiser
as code owners
The guard is unnecessary and unused.
msimberg
force-pushed
the
remove-deprecated-options
branch
from
58c5266
to
fdad1c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove:
HPX_SCHEDULER_MAX_TERMINATED_THREADS(deprecated and replaced by a runtime option).HPX_WITH_GOOGLE_PERFTOOLS(unused, or did I miss something? this is not the same asHPX_WITH_MALLOC=tcmalloc).HPX_WITH_INIT_START_OVERLOADS_COMPATIBILITY(deprecated, time for it to be removed according to the old deprecation policy).HPX_HAVE_{COROUTINE,PLUGIN}_GCC_HIDDEN_VISIBILITY(unused?).HPX_TOP_LEVEL(unset, unnecessary).