-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing boost::container::small_vector #5621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, thanks! I don't have any in-depth comments at this point. I'd like to understand how this exactly works, but I don't want that to block this from being merged (I'm happy if it passes tests).
Two questions:
- Is this inspired by: https://cpptelepathy.wordpress.com/2021/10/24/static-vector-in-terms-of-stdvector/?
- How about we put it in
hpx::(util::)detail
right away?
Yes, that reminded me of some code I had been working on a while back.
ok. |
7f08c5a
to
008d929
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
@msimberg this is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good with my limited knowledge of std::pmr
. I've left some questions to check if I've understood things correctly.
libs/core/datastructures/include/hpx/datastructures/small_vector.hpp
Outdated
Show resolved
Hide resolved
libs/core/datastructures/include/hpx/datastructures/small_vector.hpp
Outdated
Show resolved
Hide resolved
libs/core/datastructures/include/hpx/datastructures/small_vector.hpp
Outdated
Show resolved
Hide resolved
libs/core/datastructures/include/hpx/datastructures/small_vector.hpp
Outdated
Show resolved
Hide resolved
libs/core/datastructures/include/hpx/datastructures/small_vector.hpp
Outdated
Show resolved
Hide resolved
libs/core/datastructures/include/hpx/datastructures/small_vector.hpp
Outdated
Show resolved
Hide resolved
9f9effd
to
399d6c2
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
We'll need to keep a bit of an eye on the perf tests. However, don't think (hope) that this PR actually affects the timings. |
launch perftests |
This removes the dependency on
boost::container::small_vector
Working towards #3440