Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require up-to-date approvals for bors #5676

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Conversation

msimberg
Copy link
Contributor

No description provided.

aurianer
aurianer previously approved these changes Nov 24, 2021
@hkaiser hkaiser added this to the 1.8.0 milestone Nov 24, 2021
hkaiser
hkaiser previously approved these changes Nov 24, 2021
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link

bors bot commented Nov 25, 2021

👎 Rejected by too few approved reviews

@msimberg
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Nov 25, 2021
5676: Don't require up-to-date approvals for bors r=msimberg a=msimberg



Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@msimberg
Copy link
Contributor Author

All right, it seems like up_to_date_approvals = false was not enough. I've changed required_approvals to 0 for bors. That means that it comes with the same power as the regular "I'm-an-admin-I-know-what-I'm-doing-so-please-just-merge-this-button", with the addition that (some) merge problems will be detected before actually merging to master.

@bors
Copy link

bors bot commented Nov 25, 2021

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@msimberg msimberg merged commit ad6348f into master Nov 25, 2021
@msimberg msimberg deleted the msimberg-patch-2 branch November 25, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants