-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set commit status from Jenkins also for special branches #5736
Set commit status from Jenkins also for special branches #5736
Conversation
I'd be more than happy to use bors. We might have to reduce the review requirements for this, however. |
@khuck: while unrelated to this particular PR, APEX now seems to depend on zlib without checking if it's available (see: https://github.com/STEllAR-GROUP/hpx/runs/4838798276?check_suite_focus=true). Is that a known issue? Edit: please see UO-OACISS/apex#163 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bors merge |
Build succeeded: |
@hkaiser HPX / APEX does check if zlib is available. See https://github.com/UO-OACISS/apex/blob/develop/cmake/Modules/APEX_SetupZlib.cmake for the check, and |
@khuck honestly, I don't know. But this would explain things. |
@hkaiser this is required if you decide to try to use bors more extensively. Otherwise it's not necessary and can be closed without merging.