Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set commit status from Jenkins also for special branches #5736

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

msimberg
Copy link
Contributor

@hkaiser this is required if you decide to try to use bors more extensively. Otherwise it's not necessary and can be closed without merging.

@hkaiser
Copy link
Member

hkaiser commented Jan 17, 2022

@hkaiser this is required if you decide to try to use bors more extensively. Otherwise it's not necessary and can be closed without merging.

I'd be more than happy to use bors. We might have to reduce the review requirements for this, however.

@hkaiser
Copy link
Member

hkaiser commented Jan 17, 2022

@khuck: while unrelated to this particular PR, APEX now seems to depend on zlib without checking if it's available (see: https://github.com/STEllAR-GROUP/hpx/runs/4838798276?check_suite_focus=true). Is that a known issue?

Edit: please see UO-OACISS/apex#163 as well.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Jan 18, 2022

bors merge

@bors
Copy link

bors bot commented Jan 18, 2022

Build succeeded:

@bors bors bot merged commit 3a001a9 into STEllAR-GROUP:master Jan 18, 2022
@khuck
Copy link
Contributor

khuck commented Jan 18, 2022

@khuck: while unrelated to this particular PR, APEX now seems to depend on zlib without checking if it's available (see: https://github.com/STEllAR-GROUP/hpx/runs/4838798276?check_suite_focus=true). Is that a known issue?

Edit: please see UO-OACISS/apex#163 as well.

@hkaiser HPX / APEX does check if zlib is available. See https://github.com/UO-OACISS/apex/blob/develop/cmake/Modules/APEX_SetupZlib.cmake for the check, and gzstream.hpp should only get included if APEX_HAVE_ZLIB is set (https://github.com/UO-OACISS/apex/blob/b09eb7d94c9e329ce74aff29375ee9b7a384561b/src/apex/trace_event_listener.hpp#L15-L17). Does the cmake find_package(ZLIB) step only check for the library, and not the development headers?

@hkaiser
Copy link
Member

hkaiser commented Jan 18, 2022

@khuck: while unrelated to this particular PR, APEX now seems to depend on zlib without checking if it's available (see: https://github.com/STEllAR-GROUP/hpx/runs/4838798276?check_suite_focus=true). Is that a known issue?
Edit: please see UO-OACISS/apex#163 as well.

@hkaiser HPX / APEX does check if zlib is available. See https://github.com/UO-OACISS/apex/blob/develop/cmake/Modules/APEX_SetupZlib.cmake for the check, and gzstream.hpp should only get included if APEX_HAVE_ZLIB is set (https://github.com/UO-OACISS/apex/blob/b09eb7d94c9e329ce74aff29375ee9b7a384561b/src/apex/trace_event_listener.hpp#L15-L17). Does the cmake find_package(ZLIB) step only check for the library, and not the development headers?

@khuck honestly, I don't know. But this would explain things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants